Commit Graph

225 Commits

Author SHA1 Message Date
b2dbd2fed3 Changed image mark in thumbnail view to small rectangle 2014-09-27 22:05:21 +02:00
5fce009b73 Refactored main loop; properly fixes startup issue 2014-09-26 22:47:28 +02:00
c1e084357c Fixed startup in thumbnail mode with floating window 2014-09-26 20:45:15 +02:00
eaa269b6cb Revised thumbnail loading...
- Only load the thumbnails that are currently visible in the window
- Unload thumbnails that are leaving the visible area
- Much less memory needed, but scrolling is now slower
- This also unintentionally fixes issue #86
2014-09-26 10:31:03 +02:00
52e56c8924 Fixed segfault caused by image removal in thumbnail mode 2014-09-11 22:22:51 +02:00
2fbc21a205 Simplified img_frame_animate 2014-09-01 20:41:33 +02:00
f478385d59 Corrected i_alternate, fixes issue #171 2014-08-29 20:16:24 +02:00
0f6cb93a09 Bug #165: Deletion of unnecessary null pointer checks
The function "free" performs input parameter validation.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/free.html

It is therefore not needed to check a passed pointer before this function call.
A corresponding update suggestion was generated by the software "Coccinelle"
from the following semantic patch approach.
http://coccinelle.lip6.fr/

@Remove_unnecessary_pointer_checks1@
expression x;
@@
-if (x != \(0 \| NULL\))
    free(x);

@Remove_unnecessary_pointer_checks2@
expression x;
@@
-if (x != \(0 \| NULL\)) {
    free(x);
    x = \(0 \| NULL\);
-}

@Remove_unnecessary_pointer_checks3@
expression a, b;
@@
-if (a != \(0 \| NULL\) && b != \(0 \| NULL\))
+if (a)
    free(b);

@Remove_unnecessary_pointer_checks4@
expression a, b;
@@
-if (a != \(0 \| NULL\) && b != \(0 \| NULL\)) {
+if (a) {
    free(b);
    b = \(0 \| NULL\);
 }

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
2014-08-22 19:24:08 +02:00
fe3a1e326f Further simplified thumbnail marks 2014-08-18 12:45:32 +02:00
50652f63d9 Full redraw when removing files during thumbnail reloading; fixes issue #164 2014-08-17 16:31:16 +02:00
e49d38d6f9 Fixed wrong thumbnail-to-file mappings caused by file deletions 2014-08-16 22:21:51 +02:00
e267dc7793 Pass marked files to external key handler in thumbnail mode; fixes issue #135 2014-08-16 21:49:46 +02:00
284be74927 Count number of marked files 2014-08-16 21:49:46 +02:00
5b01c15176 Unified file index variable for image & thumbnail mode 2014-08-16 21:49:45 +02:00
61f61cae5f Generalized thumbnail loading, allows easier reloading of thumbnails later on 2014-08-16 21:48:52 +02:00
bb6721549b Overhauled window drawing, yet again; fixes issue #155
- Buffer for window content is bigger than the window, minimizes artifacts
  when window is resized
- Back to using XSetWindowBackgroundPixmap() instead of XCopyArea(),
  no need to handle exposure events; X server can show gray background directly
  after resize event before sxiv redraws the window contents
2014-07-28 20:36:32 +02:00
9c92de8584 Added support for multiple commands per key/button mapping; elegant fix for issue #150 2014-07-23 23:41:23 +02:00
06164c29b7 Revised command structure and key and mouse button mappings 2014-07-23 21:50:31 +02:00
5d0679b855 Show key handler status in bar while it is running 2014-06-15 14:15:48 +02:00
4cbc7346ff Timeout initial redraw 2014-05-24 10:07:14 +02:00
6d7acac3d1 Use real path of all files internally, requires _XOPEN_SOURCE>=500, fixes issue #137 2014-03-17 20:01:53 +01:00
653a6ee83b Warn once when external key combo is used and key-handler not installed 2014-02-18 21:10:44 +01:00
e2fa49ecfe Unified X atom initialization 2014-02-02 14:36:10 +01:00
f6510b0a04 Merged pull request #129 2014-01-31 13:21:23 +01:00
54d7b7f20f Use a prefix key to execute the key handler
The default prefix key is C-x, and can be changed in config.def.h. The
first key pressed after the prefix key will be passed the external key
handler, unless the key is Escape, which is used to cancel the prefix.
2014-01-31 14:17:52 +01:00
ed69b483ed Double click on thumbnail to open image 2014-01-11 22:52:37 +01:00
304fd382db Adhere to XDG Base Directory Specification; fixes issue #124 2014-01-11 22:47:41 +01:00
48954a163a Allow config.h to use multimedia keys (XF86_XK_*); fixes issue #123 2014-01-09 20:38:46 +01:00
e82397db15 Fixed handling of overloaded key mappings
Issue described here:
https://bbs.archlinux.org/viewtopic.php?pid=1117294#p1117294
2014-01-08 22:58:34 +01:00
9632dd88b9 Fixup for 9574150 2014-01-08 21:14:01 +01:00
9574150f2d Check file modification time after key handler 2014-01-08 20:31:50 +01:00
cd34aa2a6b Fixed slideshow delay corruption after GIF animation 2014-01-08 20:31:07 +01:00
6a0fa2507c Slideshow mode is back, in a simplified version 2014-01-04 19:07:15 +01:00
f2e0c492bd Moved external shell commands into exec/key-handler script
Gets called on all unset key mappings. Arguments are: key combo and
current file. Thanks to Francesco Orsenigo (xarvh) for the idea.
2014-01-02 23:19:31 +01:00
b2eae528ed Proper support for Ctrl/Shift/Alt modifiers in key & mouse mappings 2014-01-02 14:13:08 +01:00
4780ec5463 Close info file descriptor after reading 2013-11-17 12:54:55 +01:00
cc479ca5ac Fixed segfault when removing first image from file list, fixes issue #112 2013-11-16 20:19:55 +01:00
50f9ad14de Refactored remote changes 2013-11-14 17:06:20 +01:00
2737fc8b81 Merge remote-tracking branch 'ariand/gamma' 2013-11-14 14:47:36 +01:00
38bc23405d Highlight edges of marked images in thumbnail mode 2013-11-14 14:37:08 +01:00
0353e6eea2 Add support for changing the gamma value 2013-11-13 20:54:09 +01:00
450c1ed9b5 Fixed inconsistencies in navigation when removing invalid files 2013-10-21 21:57:21 +02:00
7d878bd16d Added file marks; fixes issue #94
- Command it_toggle_image_mark (bound to 'm') toggles mark of current
  image
- Command it_navigate_marked (bound to 'N'/'P') can be used to go to
  the next/previous marked image
- When option -o is given, all marked files get printed
2013-08-10 21:18:53 +02:00
98972e98f9 Fixed segfault caused by FD_ISSET() on negative fd
Reported by Kris Siwiec
2013-04-02 19:32:59 +02:00
6f05e77728 New options: -[io], read/write files from/to stdin/out
Fixes issue #84
2013-03-19 21:14:58 +01:00
825c52c33f Made bar fields more distinguishable 2013-03-19 21:14:58 +01:00
38ecea3b4d Polished info script execution 2013-03-19 21:14:56 +01:00
30802cec0f Spawn info script & update bar contents only when needed 2013-03-19 21:14:32 +01:00
f3298400e6 Spawn and read from info script without blocking 2013-03-19 21:13:44 +01:00
bf41012493 Merge remote-tracking branch '4z3/set-user-specified-sizehints' into sizehints
Conflicts:
	window.c
2013-02-09 01:21:57 +01:00