codacy issues fix

docker-compose.yml

@@ -17,8 +17,8 @@ services:
     ports:
       - 5001:5000
     environment:
-      - DATABASE_URL=postgres://postgres:postgres@api-db:5432/mpwo
-      - DATABASE_TEST_URL=postgres://postgres:postgres@api-db:5432/mpwo_test
+      - DATABASE_URL=postgres://postgres:postgres@mpwo-db:5432/mpwo
+      - DATABASE_TEST_URL=postgres://postgres:postgres@mpwo-db:5432/mpwo_test
       - FLASK_APP=server.py
       - FLASK_DEBUG=1
       - APP_SETTINGS=mpwo_api.config.DevelopmentConfig

mpwo_api/Dockerfile

@@ -1,17 +1,19 @@
 FROM python:3.6.3
 
+MAINTAINER SamR1
+
 # set working directory
 RUN mkdir -p /usr/src/app
 WORKDIR /usr/src/app
 
 # add requirements
-ADD ./requirements.txt /usr/src/app/mpwo_api/requirements.txt
+COPY ./requirements.txt /usr/src/app/mpwo_api/requirements.txt
 
 # install requirements
 RUN pip install -r mpwo_api/requirements.txt
 
 # add app
-ADD . /usr/src/app
+COPY . /usr/src/app
 
 # run server
 CMD flask run --with-threads -h 0.0.0.0

mpwo_api/db/Dockerfile

@@ -1,3 +1,5 @@
-FROM postgres
+FROM postgres:10.1
 
-ADD create.sql /docker-entrypoint-initdb.d
+MAINTAINER SamR1
+
+COPY create.sql /docker-entrypoint-initdb.d

mpwo_client/Dockerfile

@@ -1,4 +1,6 @@
-FROM node:latest
+FROM node:9.4.0
+
+MAINTAINER SamR1
 
 # set working directory
 RUN mkdir /usr/src/app
@@ -14,12 +16,12 @@ ENV NODE_ENV $NODE_ENV
 ENV REACT_APP_API_URL $REACT_APP_API_URL
 
 # install and cache app dependencies
-ADD package.json /usr/src/app/package.json
+COPY package.json /usr/src/app/package.json
 RUN yarn install --silent
 RUN yarn global add react-scripts
 
 # add app
-ADD . /usr/src/app/
+COPY . /usr/src/app/
 
 # start app
 CMD yarn start

mpwo_client/src/utils.js

@@ -1,13 +1,10 @@
-
-
 export const isLoggedIn = () => !!window.localStorage.authToken
 
 export function generateIds(arr) {
   let i = 0
-  let arrWithIds = arr.map(arr => {
-        const obj = { id: i, value: arr }
+  return arr.map(val => {
+        const obj = { id: i, value: val }
         i++
         return obj
     })
-    return arrWithIds
 }

nginx/Dockerfile

@@ -1,4 +1,6 @@
 FROM nginx:1.13.0
 
+MAINTAINER SamR1
+
 RUN rm /etc/nginx/conf.d/default.conf
-ADD /nginx.conf /etc/nginx/conf.d
+COPY /nginx.conf /etc/nginx/conf.d