Alexander/nsxiv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

code-style: use constant length array (#79)

Browse Source 
currently the code-base doesn't make use of variable length array
despite being -std=c99. it was irresponsible of me to introduce VLA in
here.

since this function will be called quite often, i did not want to make
calls to malloc and free as they have some overhead.

512 should be sufficient enough and probably is far bigger than any
window title bar can display anyways.
This commit is contained in:
N-R-K 2021-09-22 01:53:11 +06:00 committed by GitHub
parent 9c3310b676
commit c093eae971
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
window.c
View File

@ -493,7 +493,7 @@ void win_draw_rect(win_t *win, int x, int y, int w, int h, bool fill, int lw,
void win_set_title(win_t *win, const char *path) void win_set_title(win_t *win, const char *path)
{ {
const unsigned int title_max = strlen(path) + strlen(options->title_prefix) + 1; enum { title_max = 512 };
char title[title_max]; char title[title_max];
const char *basename = strrchr(path, '/') + 1; const char *basename = strrchr(path, '/') + 1;