Alexander/nsxiv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ci]: slience some clang-tidy warnings

Browse Source 
the warnings on r_readdir(), img_load_gif() and strcpy seems to be false
positives. the warning about fmt being unused is valid, but not worth
fixing with additional #ifdef guards.

use `assert` to silence the false positive cases when possible,
otherwise use a NOLINT comment with an explanation.
This commit is contained in:
NRK
2022-06-17 22:16:37 +06:00
committed by Gitea
parent 4cf17d2349
commit 5c3a796e55
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
image.c
View File

@ -21,6 +21,7 @@
#define INCLUDE_IMAGE_CONFIG
#include "config.h"
#include <assert.h>
#include <errno.h>
#include <stdlib.h>
#include <string.h>
@ -262,6 +263,7 @@ static bool img_load_gif(img_t *img, const fileinfo_t *file)
*ptr = bgpixel;
}
} else {
assert(cmap != NULL);
r = cmap->Colors[rows[i-y][j-x]].Red;
g = cmap->Colors[rows[i-y][j-x]].Green;
b = cmap->Colors[rows[i-y][j-x]].Blue;
@ -447,7 +449,7 @@ bool img_load(img_t *img, const fileinfo_t *file)
exif_auto_orientate(file);
#endif
if ((fmt = imlib_image_format()) != NULL) {
if ((fmt = imlib_image_format()) != NULL) { /* NOLINT: fmt might be unused, not worth fixing */
#if HAVE_LIBGIF
if (STREQ(fmt, "gif"))
img_load_gif(img, file);