From 0d8dcfd5210cbbf0e333cae4936f4828b8700d08 Mon Sep 17 00:00:00 2001 From: Sam Whitehead Date: Thu, 16 Sep 2021 21:27:03 +0100 Subject: [PATCH] Fix font memory leak. (#57) * Fix font memory leak. This memory leak has always been present in sxiv. The font opened on window.c:58 was never closed, so I closed it, fixing a 2kB memory leak. * document changes Co-authored-by: NRK --- CHANGELOG.md | 1 + window.c | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0d4aff1..cfa7d22 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ Fixes: * Wrong keybinding description in the manpage (#14) * .desktop entry not advertising webp support (#15) * Prevent crash when embedded into transparent window (#3) + * Small memory leak (#57) * Rare crash when showing some GIFs (#41) * Rare event when nsxiv wouldn't close after window being destroyed (#53) diff --git a/window.c b/window.c index d05bef7..b36e61b 100644 --- a/window.c +++ b/window.c @@ -61,6 +61,7 @@ void win_init_font(const win_env_t *e, const char *fontstr) fontheight = font->ascent + font->descent; FcPatternGetDouble(font->pattern, FC_SIZE, 0, &fontsize); barheight = fontheight + 2 * V_TEXT_PAD; + XftFontClose(e->dpy, font); } void win_alloc_color(const win_env_t *e, const char *name, XftColor *col)