From e010f7045fba0c9878c774921bf5d8fe230338e5 Mon Sep 17 00:00:00 2001
From: Alexander Bocken <alexander@bocken.org>
Date: Mon, 5 Jan 2026 00:01:33 +0100
Subject: [PATCH] fix: use correct short_name for base recipe links in English
 and edit pages

- Use English short_name for base recipe links when viewing English recipes
- Fix edit page to use /rezepte/edit/<shortname> instead of /{data.lang}/edit/<shortname>
- Ensures base recipe reference links work correctly in both languages
---
 src/lib/components/IngredientsPage.svelte                   | 6 +++++-
 src/lib/components/InstructionsPage.svelte                  | 6 +++++-
 src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte | 2 +-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/lib/components/IngredientsPage.svelte b/src/lib/components/IngredientsPage.svelte
index f7c98607..ceb16587 100644
--- a/src/lib/components/IngredientsPage.svelte
+++ b/src/lib/components/IngredientsPage.svelte
@@ -60,12 +60,16 @@ function flattenIngredientReferences(items, lang, visited = new Set()) {
 					? item.resolvedRecipe.translations.en.name
 					: item.resolvedRecipe.name;
 
+				const baseRecipeShortName = (lang === 'en' && item.resolvedRecipe.translations?.en?.short_name)
+					? item.resolvedRecipe.translations.en.short_name
+					: item.resolvedRecipe.short_name;
+
 				result.push({
 					type: 'section',
 					name: item.showLabel ? (item.labelOverride || baseRecipeName) : '',
 					list: combinedList,
 					isReference: item.showLabel,
-					short_name: item.resolvedRecipe.short_name
+					short_name: baseRecipeShortName
 				});
 			}
 		} else if (item.type === 'section' || !item.type) {
diff --git a/src/lib/components/InstructionsPage.svelte b/src/lib/components/InstructionsPage.svelte
index 5b2f3c5d..3ed6e041 100644
--- a/src/lib/components/InstructionsPage.svelte
+++ b/src/lib/components/InstructionsPage.svelte
@@ -56,12 +56,16 @@ function flattenInstructionReferences(items, lang, visited = new Set()) {
 					? item.resolvedRecipe.translations.en.name
 					: item.resolvedRecipe.name;
 
+				const baseRecipeShortName = (lang === 'en' && item.resolvedRecipe.translations?.en?.short_name)
+					? item.resolvedRecipe.translations.en.short_name
+					: item.resolvedRecipe.short_name;
+
 				result.push({
 					type: 'section',
 					name: item.showLabel ? (item.labelOverride || baseRecipeName) : '',
 					steps: combinedSteps,
 					isReference: item.showLabel,
-					short_name: item.resolvedRecipe.short_name
+					short_name: baseRecipeShortName
 				});
 			}
 		} else if (item.type === 'section' || !item.type) {
diff --git a/src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte b/src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte
index 7725ddf0..a436448a 100644
--- a/src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte
+++ b/src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte
@@ -492,7 +492,7 @@ button.action_button{
 				<ul style="color: var(--nord1); list-style-position: inside;">
 					{#each refData.references as ref}
 						<li>
-							<a href="/{data.lang}/edit/{ref.short_name}" style="color: var(--nord10); font-weight: bold; text-decoration: underline;">
+							<a href="/rezepte/edit/{ref.short_name}" style="color: var(--nord10); font-weight: bold; text-decoration: underline;">
 								{ref.name}
 							</a>
 						</li>