From d5ed0fce58ee8aeeb2a5496cf7c62dee897d9c58 Mon Sep 17 00:00:00 2001
From: Alexander Bocken <alexander@bocken.org>
Date: Wed, 17 Sep 2025 20:43:48 +0200
Subject: [PATCH] feat: enable edit buttons for all payments and remove delete
 functionality
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Remove createdBy restriction from edit buttons in PaymentModal and view pages
- All authenticated users can now edit any payment (including executed recurring payments)
- Remove delete payment functionality from both modal and view pages
- Replace inline edit button with consistent EditButton component in PaymentModal
- Clean up unused delete-related code and variables

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 src/lib/components/PaymentModal.svelte        | 96 ++++++++++++++++---
 .../cospend/payments/view/[id]/+page.svelte   | 28 +-----
 2 files changed, 85 insertions(+), 39 deletions(-)

diff --git a/src/lib/components/PaymentModal.svelte b/src/lib/components/PaymentModal.svelte
index c2e1088..f1c5fb2 100644
--- a/src/lib/components/PaymentModal.svelte
+++ b/src/lib/components/PaymentModal.svelte
@@ -214,15 +214,6 @@
           {/if}
 
           <div class="panel-actions">
-            {#if payment && payment.createdBy === session?.user?.nickname}
-              <button 
-                class="btn-danger" 
-                on:click={deletePayment}
-                disabled={deleting}
-              >
-                {deleting ? 'Deleting...' : 'Delete Payment'}
-              </button>
-            {/if}
             <button class="btn-secondary" on:click={closeModal}>Close</button>
           </div>
         </div>
@@ -230,7 +221,7 @@
   </div>
 </div>
 
-{#if payment && payment.createdBy === session?.user?.nickname}
+{#if payment}
   <EditButton href="/cospend/payments/edit/{paymentId}" />
 {/if}
 
@@ -480,6 +471,9 @@
     cursor: pointer;
     transition: all 0.2s;
     border: none;
+    text-decoration: none;
+    display: inline-block;
+    text-align: center;
   }
 
   .btn-primary {
@@ -616,11 +610,50 @@
     }
   }
 
+  @media (max-width: 768px) {
+    .panel-content {
+      height: 100vh;
+    }
+    
+    .panel-header {
+      padding: 1rem;
+      position: sticky;
+      top: 0;
+      z-index: 10;
+    }
+
+    .panel-header h2 {
+      font-size: 1.2rem;
+    }
+
+    .close-button {
+      padding: 0.75rem;
+    }
+  }
+
   @media (max-width: 600px) {
+    .panel-header h2 {
+      font-size: 1.1rem;
+    }
+
     .payment-header {
       flex-direction: column;
       gap: 1rem;
       text-align: center;
+      padding: 1rem;
+    }
+
+    .payment-info {
+      padding: 1rem;
+    }
+
+    .splits-section {
+      padding: 1rem;
+    }
+
+    .panel-actions {
+      padding: 1rem;
+      flex-direction: column;
     }
 
     .receipt-image {
@@ -629,16 +662,55 @@
 
     .info-grid {
       grid-template-columns: 1fr;
+      gap: 0.75rem;
+      margin-bottom: 1rem;
     }
 
-    .panel-actions {
-      flex-direction: column;
+    .info-item {
+      gap: 0.125rem;
+    }
+
+    .label {
+      font-size: 0.8rem;
+    }
+
+    .value {
+      font-size: 0.9rem;
+    }
+
+    .description {
+      padding-top: 1rem;
+      margin-bottom: 0;
+    }
+
+    .description h3 {
+      font-size: 0.95rem;
+      margin-bottom: 0.5rem;
+    }
+
+    .description p {
+      font-size: 0.9rem;
+      line-height: 1.4;
+    }
+
+    .splits-section h3 {
+      font-size: 0.95rem;
+      margin-bottom: 0.75rem;
+    }
+
+    .splits-list {
+      gap: 0.5rem;
     }
 
     .split-item {
       flex-direction: column;
       align-items: flex-start;
       gap: 0.5rem;
+      padding: 0.75rem;
+    }
+
+    .split-amount {
+      font-size: 0.9rem;
     }
   }
 </style>
\ No newline at end of file
diff --git a/src/routes/cospend/payments/view/[id]/+page.svelte b/src/routes/cospend/payments/view/[id]/+page.svelte
index d2783a0..5ee110b 100644
--- a/src/routes/cospend/payments/view/[id]/+page.svelte
+++ b/src/routes/cospend/payments/view/[id]/+page.svelte
@@ -72,32 +72,6 @@
     }
   }
 
-  let deleting = false;
-
-  async function deletePayment() {
-    if (!confirm('Are you sure you want to delete this payment? This action cannot be undone.')) {
-      return;
-    }
-
-    try {
-      deleting = true;
-      const response = await fetch(`/api/cospend/payments/${data.paymentId}`, {
-        method: 'DELETE'
-      });
-
-      if (!response.ok) {
-        throw new Error('Failed to delete payment');
-      }
-
-      // Redirect to dashboard after successful deletion
-      goto('/cospend');
-      
-    } catch (err) {
-      error = err.message;
-    } finally {
-      deleting = false;
-    }
-  }
 </script>
 
 <svelte:head>
@@ -199,7 +173,7 @@
   {/if}
 </main>
 
-{#if payment && payment.createdBy === data.session.user.nickname}
+{#if payment}
   <EditButton href="/cospend/payments/edit/{data.paymentId}" />
 {/if}