From a432e6ebd5bd64c47db15adc5d44977d480ff768 Mon Sep 17 00:00:00 2001
From: Alexander Bocken <alexander@bocken.org>
Date: Tue, 7 Apr 2026 19:50:34 +0200
Subject: [PATCH] fix: use dynamic recipeLang in API calls instead of hardcoded
 /api/rezepte

Client-side navigation to /recipes hung because getUserFavorites and
other endpoints were hardcoded to /api/rezepte, causing fetch mismatches
during SvelteKit's client-side routing.
---
 package.json                                             | 2 +-
 src/lib/components/FavoriteButton.svelte                 | 5 ++++-
 src/lib/components/recipes/Search.svelte                 | 2 +-
 src/lib/server/favorites.ts                              | 9 +++++----
 src/routes/[recipeLang=recipeLang]/+page.server.ts       | 2 +-
 .../[recipeLang=recipeLang]/[name]/+page.server.ts       | 2 +-
 src/routes/[recipeLang=recipeLang]/[name]/+page.ts       | 2 +-
 .../category/[category]/+page.server.ts                  | 2 +-
 src/routes/[recipeLang=recipeLang]/icon/+page.ts         | 4 ++--
 .../[recipeLang=recipeLang]/icon/[icon]/+page.server.ts  | 4 ++--
 .../[recipeLang=recipeLang]/search/+page.server.ts       | 2 +-
 .../[recipeLang=recipeLang]/season/+page.server.ts       | 2 +-
 .../season/[month]/+page.server.ts                       | 2 +-
 .../[recipeLang=recipeLang]/tag/[tag]/+page.server.ts    | 2 +-
 14 files changed, 23 insertions(+), 19 deletions(-)

diff --git a/package.json b/package.json
index 3e53d65..8c2f1d8 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "homepage",
-	"version": "1.4.2",
+	"version": "1.4.3",
 	"private": true,
 	"type": "module",
 	"scripts": {
diff --git a/src/lib/components/FavoriteButton.svelte b/src/lib/components/FavoriteButton.svelte
index 177192e..c43f7df 100644
--- a/src/lib/components/FavoriteButton.svelte
+++ b/src/lib/components/FavoriteButton.svelte
@@ -1,9 +1,12 @@
 <script lang="ts">
   import { browser } from '$app/environment';
   import { enhance } from '$app/forms';
+  import { page } from '$app/stores';
 
   let { recipeId, isFavorite = $bindable(false), isLoggedIn = false } = $props<{ recipeId: string, isFavorite?: boolean, isLoggedIn?: boolean }>();
 
+  const recipeLang = $derived($page.url.pathname.split('/')[1] || 'rezepte');
+
   let isLoading = $state(false);
 
   async function toggleFavorite(event: Event) {
@@ -17,7 +20,7 @@
       
       try {
         const method = isFavorite ? 'DELETE' : 'POST';
-        const response = await fetch('/api/rezepte/favorites', {
+        const response = await fetch(`/api/${recipeLang}/favorites`, {
           method,
           headers: {
             'Content-Type': 'application/json',
diff --git a/src/lib/components/recipes/Search.svelte b/src/lib/components/recipes/Search.svelte
index c0af6b8..68fd3c8 100644
--- a/src/lib/components/recipes/Search.svelte
+++ b/src/lib/components/recipes/Search.svelte
@@ -284,7 +284,7 @@
                 const apiBase = `/api/${isEnglish ? 'recipes' : 'rezepte'}`;
                 const [tagsRes, iconsRes] = await Promise.all([
                     fetch(`${apiBase}/items/tag`),
-                    fetch('/api/rezepte/items/icon')
+                    fetch(`${apiBase}/items/icon`)
                 ]);
                 availableTags = await tagsRes.json();
                 availableIcons = await iconsRes.json();
diff --git a/src/lib/server/favorites.ts b/src/lib/server/favorites.ts
index 434a822..db79d90 100644
--- a/src/lib/server/favorites.ts
+++ b/src/lib/server/favorites.ts
@@ -7,7 +7,7 @@ import type { Session } from '@auth/sveltekit';
 
 type BriefRecipeWithFavorite = BriefRecipeType & { isFavorite: boolean };
 
-export async function getUserFavorites(fetch: typeof globalThis.fetch, locals: App.Locals): Promise<string[]> {
+export async function getUserFavorites(fetch: typeof globalThis.fetch, locals: App.Locals, recipeLang = 'rezepte'): Promise<string[]> {
     const session = await locals.auth();
 
     if (!session?.user?.nickname) {
@@ -15,7 +15,7 @@ export async function getUserFavorites(fetch: typeof globalThis.fetch, locals: A
     }
 
     try {
-        const favRes = await fetch('/api/rezepte/favorites');
+        const favRes = await fetch(`/api/${recipeLang}/favorites`);
         if (favRes.ok) {
             const favData = await favRes.json();
             return favData.favorites || [];
@@ -44,11 +44,12 @@ export function addFavoriteStatusToRecipes(recipes: BriefRecipeType[], userFavor
 export async function loadRecipesWithFavorites(
     fetch: typeof globalThis.fetch,
     locals: App.Locals,
-    recipeLoader: () => Promise<BriefRecipeType[]>
+    recipeLoader: () => Promise<BriefRecipeType[]>,
+    recipeLang = 'rezepte'
 ): Promise<{ recipes: BriefRecipeWithFavorite[], session: Session | null }> {
     const [recipes, userFavorites, session] = await Promise.all([
         recipeLoader(),
-        getUserFavorites(fetch, locals),
+        getUserFavorites(fetch, locals, recipeLang),
         locals.auth()
     ]);
 
diff --git a/src/routes/[recipeLang=recipeLang]/+page.server.ts b/src/routes/[recipeLang=recipeLang]/+page.server.ts
index 4214e58..bcd1931 100644
--- a/src/routes/[recipeLang=recipeLang]/+page.server.ts
+++ b/src/routes/[recipeLang=recipeLang]/+page.server.ts
@@ -8,7 +8,7 @@ export const load: PageServerLoad = async ({ fetch, locals, params }) => {
     // Fetch all_brief, favorites, and session in parallel
     const [res_all_brief, userFavorites, session] = await Promise.all([
         fetch(`${apiBase}/items/all_brief`).then(r => r.json()),
-        getUserFavorites(fetch, locals),
+        getUserFavorites(fetch, locals, params.recipeLang),
         locals.auth()
     ]);
 
diff --git a/src/routes/[recipeLang=recipeLang]/[name]/+page.server.ts b/src/routes/[recipeLang=recipeLang]/[name]/+page.server.ts
index 1c827b6..d9a043f 100644
--- a/src/routes/[recipeLang=recipeLang]/[name]/+page.server.ts
+++ b/src/routes/[recipeLang=recipeLang]/[name]/+page.server.ts
@@ -50,7 +50,7 @@ export const actions: Actions = {
         try {
             // Use the existing API endpoint
             const method = isFavorite ? 'DELETE' : 'POST';
-            const response = await fetch('/api/rezepte/favorites', {
+            const response = await fetch(`/api/${url.pathname.split('/')[1]}/favorites`, {
                 method,
                 headers: {
                     'Content-Type': 'application/json',
diff --git a/src/routes/[recipeLang=recipeLang]/[name]/+page.ts b/src/routes/[recipeLang=recipeLang]/[name]/+page.ts
index 96dbd21..a5c23e9 100644
--- a/src/routes/[recipeLang=recipeLang]/[name]/+page.ts
+++ b/src/routes/[recipeLang=recipeLang]/[name]/+page.ts
@@ -77,7 +77,7 @@ export const load: PageLoad = async ({ fetch, params, url, data }) => {
     // Check if this recipe is favorited by the user
     let isFavorite = false;
     try {
-        const favRes = await fetch(`/api/rezepte/favorites/check/${params.name}`);
+        const favRes = await fetch(`/api/${params.recipeLang}/favorites/check/${params.name}`);
         if (favRes.ok) {
             const favData = await favRes.json();
             isFavorite = favData.isFavorite;
diff --git a/src/routes/[recipeLang=recipeLang]/category/[category]/+page.server.ts b/src/routes/[recipeLang=recipeLang]/category/[category]/+page.server.ts
index f03ca0a..3575608 100644
--- a/src/routes/[recipeLang=recipeLang]/category/[category]/+page.server.ts
+++ b/src/routes/[recipeLang=recipeLang]/category/[category]/+page.server.ts
@@ -7,7 +7,7 @@ export const load: PageServerLoad = async ({ fetch, locals, params }) => {
     const [res, allRes, userFavorites, session] = await Promise.all([
         fetch(`${apiBase}/items/category/${params.category}`),
         fetch(`${apiBase}/items/all_brief`),
-        getUserFavorites(fetch, locals),
+        getUserFavorites(fetch, locals, params.recipeLang),
         locals.auth()
     ]);
 
diff --git a/src/routes/[recipeLang=recipeLang]/icon/+page.ts b/src/routes/[recipeLang=recipeLang]/icon/+page.ts
index 5cdf5d3..a3364cf 100644
--- a/src/routes/[recipeLang=recipeLang]/icon/+page.ts
+++ b/src/routes/[recipeLang=recipeLang]/icon/+page.ts
@@ -3,7 +3,7 @@ import { browser } from '$app/environment';
 import { isOffline, canUseOfflineData } from '$lib/offline/helpers';
 import { getAllIcons, isOfflineDataAvailable } from '$lib/offline/db';
 
-export const load: PageLoad = async ({ fetch }) => {
+export const load: PageLoad = async ({ fetch, params }) => {
     // Check if we should use offline data
     if (browser && isOffline() && canUseOfflineData()) {
         try {
@@ -19,7 +19,7 @@ export const load: PageLoad = async ({ fetch }) => {
 
     // Online mode - fetch from API
     try {
-        const res_icons = await fetch(`/api/rezepte/items/icon`);
+        const res_icons = await fetch(`/api/${params.recipeLang}/items/icon`);
         const icons = await res_icons.json();
         return { icons, isOffline: false };
     } catch (error) {
diff --git a/src/routes/[recipeLang=recipeLang]/icon/[icon]/+page.server.ts b/src/routes/[recipeLang=recipeLang]/icon/[icon]/+page.server.ts
index e0effe9..ea7cc52 100644
--- a/src/routes/[recipeLang=recipeLang]/icon/[icon]/+page.server.ts
+++ b/src/routes/[recipeLang=recipeLang]/icon/[icon]/+page.server.ts
@@ -6,8 +6,8 @@ export const load: PageServerLoad = async ({ fetch, locals, params }) => {
 
     const [item_season, icons, userFavorites, session] = await Promise.all([
         fetch(`${apiBase}/items/icon/` + params.icon).then(r => r.json()),
-        fetch(`/api/rezepte/items/icon`).then(r => r.json()),
-        getUserFavorites(fetch, locals),
+        fetch(`${apiBase}/items/icon`).then(r => r.json()),
+        getUserFavorites(fetch, locals, params.recipeLang),
         locals.auth()
     ]);
 
diff --git a/src/routes/[recipeLang=recipeLang]/search/+page.server.ts b/src/routes/[recipeLang=recipeLang]/search/+page.server.ts
index 2ed0a18..de4e87c 100644
--- a/src/routes/[recipeLang=recipeLang]/search/+page.server.ts
+++ b/src/routes/[recipeLang=recipeLang]/search/+page.server.ts
@@ -48,7 +48,7 @@ export const load: PageServerLoad = async ({ url, fetch, params, locals }) => {
         const [searchResponse, allRecipesResponse, userFavorites] = await Promise.all([
             fetch(apiUrl.toString()),
             fetch(`${apiBase}/items/all_brief`),
-            getUserFavorites(fetch, locals)
+            getUserFavorites(fetch, locals, params.recipeLang)
         ]);
 
         const results = await searchResponse.json();
diff --git a/src/routes/[recipeLang=recipeLang]/season/+page.server.ts b/src/routes/[recipeLang=recipeLang]/season/+page.server.ts
index 5e289ae..c8bbfe8 100644
--- a/src/routes/[recipeLang=recipeLang]/season/+page.server.ts
+++ b/src/routes/[recipeLang=recipeLang]/season/+page.server.ts
@@ -10,7 +10,7 @@ export const load: PageServerLoad = async ({ fetch, locals, params }) => {
 
     // Get user favorites and session
     const [userFavorites, session] = await Promise.all([
-        getUserFavorites(fetch, locals),
+        getUserFavorites(fetch, locals, params.recipeLang),
         locals.auth()
     ]);
 
diff --git a/src/routes/[recipeLang=recipeLang]/season/[month]/+page.server.ts b/src/routes/[recipeLang=recipeLang]/season/[month]/+page.server.ts
index 2af0817..3d96f2d 100644
--- a/src/routes/[recipeLang=recipeLang]/season/[month]/+page.server.ts
+++ b/src/routes/[recipeLang=recipeLang]/season/[month]/+page.server.ts
@@ -9,7 +9,7 @@ export const load: PageServerLoad = async ({ fetch, locals, params }) => {
 
     // Get user favorites and session
     const [userFavorites, session] = await Promise.all([
-        getUserFavorites(fetch, locals),
+        getUserFavorites(fetch, locals, params.recipeLang),
         locals.auth()
     ]);
 
diff --git a/src/routes/[recipeLang=recipeLang]/tag/[tag]/+page.server.ts b/src/routes/[recipeLang=recipeLang]/tag/[tag]/+page.server.ts
index be78416..6165c6c 100644
--- a/src/routes/[recipeLang=recipeLang]/tag/[tag]/+page.server.ts
+++ b/src/routes/[recipeLang=recipeLang]/tag/[tag]/+page.server.ts
@@ -7,7 +7,7 @@ export const load: PageServerLoad = async ({ fetch, locals, params }) => {
     const [res_tag, allRes, userFavorites, session] = await Promise.all([
         fetch(`${apiBase}/items/tag/${params.tag}`),
         fetch(`${apiBase}/items/all_brief`),
-        getUserFavorites(fetch, locals),
+        getUserFavorites(fetch, locals, params.recipeLang),
         locals.auth()
     ]);