From 88f3909634225d783a88bad6569baef96668d424 Mon Sep 17 00:00:00 2001
From: Alexander Bocken <alexander@bocken.org>
Date: Fri, 3 Apr 2026 08:44:32 +0200
Subject: [PATCH] chore: Svelte 5 syntax updates, a11y fixes, and dead CSS
 removal

Replace deprecated svelte:component with direct component invocation,
use span instead of label for non-input controls with role="group",
remove unused imports and dead CSS rules.
---
 .../components/tasks/StickerCalendar.svelte   |  2 +-
 src/lib/components/tasks/StickerPopup.svelte  |  1 +
 src/lib/components/tasks/TaskForm.svelte      | 22 +++++++++----------
 .../edit/[name]/+page.svelte                  | 18 ++-------------
 .../cospend/payments/edit/[id]/+page.svelte   |  3 ---
 .../[workout=fitnessWorkout]/+page.svelte     |  6 ++---
 src/routes/tasks/+page.svelte                 |  3 ++-
 7 files changed, 20 insertions(+), 35 deletions(-)

diff --git a/src/lib/components/tasks/StickerCalendar.svelte b/src/lib/components/tasks/StickerCalendar.svelte
index ad52c93..2200700 100644
--- a/src/lib/components/tasks/StickerCalendar.svelte
+++ b/src/lib/components/tasks/StickerCalendar.svelte
@@ -3,7 +3,7 @@
   import { getStickerById } from '$lib/utils/stickers';
   import {
     startOfMonth, endOfMonth, startOfWeek, endOfWeek,
-    eachDayOfInterval, isSameMonth, isSameDay, isToday, format, addMonths, subMonths
+    eachDayOfInterval, isSameMonth, isToday, format, addMonths, subMonths
   } from 'date-fns';
   import { de } from 'date-fns/locale';
 
diff --git a/src/lib/components/tasks/StickerPopup.svelte b/src/lib/components/tasks/StickerPopup.svelte
index d481f04..cc78172 100644
--- a/src/lib/components/tasks/StickerPopup.svelte
+++ b/src/lib/components/tasks/StickerPopup.svelte
@@ -16,6 +16,7 @@
 <!-- svelte-ignore a11y_no_static_element_interactions -->
 <div class="popup-backdrop" transition:fade={{ duration: 200 }} onclick={onclose} onkeydown={e => e.key === 'Escape' && onclose?.()}>
   <!-- svelte-ignore a11y_no_static_element_interactions -->
+  <!-- svelte-ignore a11y_click_events_have_key_events -->
   <div class="popup-card" transition:scale={{ start: 0.5, duration: 500, easing: elasticOut }} onclick={e => e.stopPropagation()}>
     <div class="sticker-display" style="--rarity-color: {getRarityColor(sticker.rarity)}">
       <img class="sticker-img" src="/stickers/{sticker.image}" alt={sticker.name} />
diff --git a/src/lib/components/tasks/TaskForm.svelte b/src/lib/components/tasks/TaskForm.svelte
index 17d7ac3..f7d85b9 100644
--- a/src/lib/components/tasks/TaskForm.svelte
+++ b/src/lib/components/tasks/TaskForm.svelte
@@ -171,8 +171,8 @@
   </div>
 
   <div class="field">
-    <label>Zugewiesen an</label>
-    <div class="assignee-buttons">
+    <span class="label">Zugewiesen an</span>
+    <div class="assignee-buttons" role="group" aria-label="Zugewiesen an">
       {#each USERS as user}
         <button
           type="button"
@@ -195,7 +195,7 @@
 
   <!-- Tags: desktop = input + dropdown, mobile = pill buttons -->
   <div class="field">
-    <label>Tags</label>
+    <span class="label">Tags</span>
     <span class="hint">Bestimmen Sticker-Belohnungen</span>
 
     <!-- Desktop: input with dropdown -->
@@ -212,9 +212,9 @@
         />
         {#if tagDropdownOpen && filteredDropdownTags.length > 0}
           <div class="tag-dropdown">
-            {#each filteredDropdownTags as { tag, icon }}
+            {#each filteredDropdownTags as { tag, icon: Icon }}
               <button type="button" class="tag-dropdown-item" onclick={() => selectDropdownTag(tag)}>
-                <svelte:component this={icon} size={14} />
+                <Icon size={14} />
                 {tag}
               </button>
             {/each}
@@ -225,14 +225,14 @@
 
     <!-- Mobile: pill buttons -->
     <div class="tag-pills-mobile">
-      {#each AVAILABLE_TAGS as { tag, icon }}
+      {#each AVAILABLE_TAGS as { tag, icon: Icon }}
         <button
           type="button"
           class="tag-pill"
           class:selected={selectedTags.includes(tag)}
           onclick={() => toggleTag(tag)}
         >
-          <svelte:component this={icon} size={14} />
+          <Icon size={14} />
           {tag}
         </button>
       {/each}
@@ -245,7 +245,7 @@
           {@const Icon = getTagIcon(tag)}
           <button type="button" class="tag-chip selected" onclick={() => toggleTag(tag)}>
             {#if Icon}
-              <svelte:component this={Icon} size={13} />
+              <Icon size={13} />
             {/if}
             {tag}
             <span class="remove-x">&times;</span>
@@ -256,7 +256,7 @@
   </div>
 
   <div class="field">
-    <label>Schwierigkeit</label>
+    <span class="label">Schwierigkeit</span>
     <span class="hint">Schwerere Aufgaben geben seltenere Sticker</span>
     <div class="difficulty-buttons">
       <button
@@ -323,7 +323,7 @@
     {/if}
 
     <div class="field">
-      <label>Nächstes Fälligkeitsdatum berechnen ab</label>
+      <span class="label">Nächstes Fälligkeitsdatum berechnen ab</span>
       <div class="refresh-mode-buttons">
         <button
           type="button"
@@ -404,7 +404,7 @@
   .field {
     margin-bottom: 0.75rem;
   }
-  .field label {
+  .field label, .field .label {
     display: block;
     font-size: 0.78rem;
     font-weight: 600;
diff --git a/src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte b/src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte
index 3e5f605..47da1fd 100644
--- a/src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte
+++ b/src/routes/[recipeLang=recipeLang]/edit/[name]/+page.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import { enhance } from '$app/forms';
-	import { tick } from 'svelte';
+	import { tick, untrack } from 'svelte';
 	import type { ActionData, PageData } from './$types';
 	import SaveFab from '$lib/components/SaveFab.svelte';
 	import Cross from '$lib/assets/icons/Cross.svelte';
@@ -282,7 +282,7 @@
 
 	// Pre-init all toggles to false (prevents bind:checked={undefined}), then load real state
 	initGlobalToggles();
-	if (nutritionMappings.length > 0) {
+	if (untrack(() => nutritionMappings).length > 0) {
 		loadGlobalOverwrites().then(() => {
 			// Re-init with real overwrite data (overwrite the false defaults)
 			for (const m of nutritionMappings) {
@@ -474,20 +474,6 @@
 	h3 {
 		text-align: center;
 	}
-	button.action_button {
-		animation: unset !important;
-		font-size: 1.3rem;
-		color: white;
-	}
-	.submit_buttons {
-		display: flex;
-		margin-inline: auto;
-		max-width: 1000px;
-		margin-block: 1rem;
-		justify-content: center;
-		align-items: center;
-		gap: 2rem;
-	}
 	@media (prefers-color-scheme: dark) {
     :global(:root:not([data-theme="light"])) .title {
 			background-color: var(--nord6-dark);
diff --git a/src/routes/cospend/payments/edit/[id]/+page.svelte b/src/routes/cospend/payments/edit/[id]/+page.svelte
index aad8762..6ea762c 100644
--- a/src/routes/cospend/payments/edit/[id]/+page.svelte
+++ b/src/routes/cospend/payments/edit/[id]/+page.svelte
@@ -932,9 +932,6 @@
       align-items: stretch;
     }
 
-    .main-actions {
-      flex-direction: column;
-    }
 
     .amount-currency {
       flex-direction: column;
diff --git a/src/routes/fitness/[workout=fitnessWorkout]/+page.svelte b/src/routes/fitness/[workout=fitnessWorkout]/+page.svelte
index 03819dd..7c88248 100644
--- a/src/routes/fitness/[workout=fitnessWorkout]/+page.svelte
+++ b/src/routes/fitness/[workout=fitnessWorkout]/+page.svelte
@@ -535,8 +535,8 @@
 						</div>
 					{/if}
 					<div class="editor-gps-options">
-						<label class="editor-label">Activity</label>
-						<div class="activity-chips">
+						<span class="editor-label">Activity</span>
+						<div class="activity-chips" role="group" aria-label="Activity">
 							{#each /** @type {const} */ (['running', 'walking', 'cycling', 'hiking']) as act}
 								<button
 									class="activity-chip"
@@ -547,7 +547,7 @@
 							{/each}
 						</div>
 
-						<label class="editor-label">Interval Training</label>
+						<span class="editor-label">Interval Training</span>
 						<div class="interval-select">
 							<button
 								class="interval-option"
diff --git a/src/routes/tasks/+page.svelte b/src/routes/tasks/+page.svelte
index 18e22a4..9c0bc8e 100644
--- a/src/routes/tasks/+page.svelte
+++ b/src/routes/tasks/+page.svelte
@@ -270,7 +270,8 @@
               {#each task.tags as tag}
                 <span class="tag">
                   {#if TAG_ICONS[tag]}
-                    <svelte:component this={TAG_ICONS[tag]} size={14} />
+                    {@const Icon = TAG_ICONS[tag]}
+                    <Icon size={14} />
                   {/if}
                   {tag}
                 </span>