fix: resolve Svelte 5 migration warnings and improve accessibility
All checks were successful
CI / update (push) Successful in 2m2s

- Fix state_referenced_locally warnings by extracting initial values to constants
- Remove unused CSS selectors (subheading, header-actions, back-actions)
- Add ARIA roles and keyboard handlers to settlement options
- Add a11y ignore comment for custom checkbox implementation
This commit is contained in:
2026-01-10 17:05:38 +01:00
parent 5c8605c690
commit 7ab3482850
12 changed files with 25 additions and 2640 deletions

View File

@@ -170,8 +170,11 @@
<h3>Money You're Owed</h3>
{#each debtData.whoOwesMe as debt}
<div class="settlement-option"
role="button"
tabindex="0"
class:selected={selectedSettlement?.type === 'receive' && selectedSettlement?.from === debt.username}
on:click={() => selectSettlement('receive', debt.username, debt.netAmount)}>
onclick={() => selectSettlement('receive', debt.username, debt.netAmount)}
onkeydown={(e) => { if (e.key === 'Enter' || e.key === ' ') { e.preventDefault(); selectSettlement('receive', debt.username, debt.netAmount); } }}>
<div class="settlement-user">
<ProfilePicture username={debt.username} size={40} />
<div class="user-details">
@@ -192,8 +195,11 @@
<h3>Money You Owe</h3>
{#each debtData.whoIOwe as debt}
<div class="settlement-option"
role="button"
tabindex="0"
class:selected={selectedSettlement?.type === 'pay' && selectedSettlement?.to === debt.username}
on:click={() => selectSettlement('pay', debt.username, debt.netAmount)}>
onclick={() => selectSettlement('pay', debt.username, debt.netAmount)}
onkeydown={(e) => { if (e.key === 'Enter' || e.key === ' ') { e.preventDefault(); selectSettlement('pay', debt.username, debt.netAmount); } }}>
<div class="settlement-user">
<ProfilePicture username={debt.username} size={40} />
<div class="user-details">
@@ -259,7 +265,7 @@
<div class="settlement-actions">
<button
class="btn btn-settlement"
on:click={processSettlement}
onclick={processSettlement}
disabled={submitting || !settlementAmount}>
{#if submitting}
Recording Settlement...
@@ -267,7 +273,7 @@
Record Settlement
{/if}
</button>
<button class="btn btn-secondary" on:click={() => selectedSettlement = null}>
<button class="btn btn-secondary" onclick={() => selectedSettlement = null}>
Cancel
</button>
</div>
@@ -668,11 +674,6 @@
cursor: not-allowed;
}
.back-actions {
text-align: center;
margin-top: 2rem;
}
.actions {
margin-top: 1.5rem;
}