Alexander/dwm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

reflow tiled layouts on size hint changes

Browse Source 
PropertyNotify on WM_NORMAL_HINTS only refreshed mina/maxa; layout
math never reran, so mpv clip switches with new aspect kept the
previous master width until something else triggered arrange.

Trigger arrange() when aspect actually changes. Compute altw from
c->maxa instead of WIDTH(c)/HEIGHT(c) so the first reflow picks up
the new aspect rather than the stale geometry.
This commit is contained in:
Alexander Bocken
2026-04-18 13:35:16 +02:00
parent 9146a6d6d6
commit aad610d178
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dwm.c
+12 -5
View File
@@ -689,7 +689,7 @@ deck(Monitor *m) {
return; return;
if (n == 1){ if (n == 1){
c = nexttiled(m->clients); c = nexttiled(m->clients);
altw = WIDTH(c) * m->wh / HEIGHT(c); /*use max window height but preserve aspect ratio */ altw = c->maxa > 0 ? m->wh * c->maxa : WIDTH(c) * m->wh / HEIGHT(c);
if ( c->mina > 0 && altw < c->mon->mw ){ if ( c->mina > 0 && altw < c->mon->mw ){
nx = m->mx + (m->mw - altw ) / 2; nx = m->mx + (m->mw - altw ) / 2;
resize(c, nx , c->y, altw , c->h, 0); resize(c, nx , c->y, altw , c->h, 0);
@@ -700,7 +700,7 @@ deck(Monitor *m) {
mw = m->nmaster ? m->ww * m->mfact : 0; mw = m->nmaster ? m->ww * m->mfact : 0;
if ( m->nmaster == 1){ if ( m->nmaster == 1){
c = nexttiled(m->clients); c = nexttiled(m->clients);
altw = WIDTH(c) * m->wh / HEIGHT(c); /*use max window height but preserve aspect ratio */ altw = c->maxa > 0 ? m->wh * c->maxa : WIDTH(c) * m->wh / HEIGHT(c);
mw = c->mina > 0 && altw < mw ? altw : mw; mw = c->mina > 0 && altw < mw ? altw : mw;
} }
snprintf(m->ltsymbol, sizeof m->ltsymbol, "[%d]", n - m->nmaster); snprintf(m->ltsymbol, sizeof m->ltsymbol, "[%d]", n - m->nmaster);
@@ -1315,7 +1315,14 @@ propertynotify(XEvent *e)
arrange(c->mon); arrange(c->mon);
break; break;
case XA_WM_NORMAL_HINTS: case XA_WM_NORMAL_HINTS:
{
float oldmina = c->mina, oldmaxa = c->maxa;
updatesizehints(c); updatesizehints(c);
if ((c->mina != oldmina || c->maxa != oldmaxa)
&& !c->isfloating
&& c->mon->lt[c->mon->sellt]->arrange)
arrange(c->mon);
}
break; break;
case XA_WM_HINTS: case XA_WM_HINTS:
updatewmhints(c); updatewmhints(c);
@@ -1802,7 +1809,7 @@ tile(Monitor *m)
return; return;
if (n == 1){ if (n == 1){
c = nexttiled(m->clients); c = nexttiled(m->clients);
altw = WIDTH(c) * m->wh / HEIGHT(c); /*use max window height but preserve aspect ratio */ altw = c->maxa > 0 ? m->wh * c->maxa : WIDTH(c) * m->wh / HEIGHT(c);
if ( c->mina > 0 && altw < c->mon->mw ){ if ( c->mina > 0 && altw < c->mon->mw ){
nx = m->mx + (m->mw - altw ) / 2; nx = m->mx + (m->mw - altw ) / 2;
resize(c, nx , c->y, altw , c->h, 0); resize(c, nx , c->y, altw , c->h, 0);
@@ -1814,7 +1821,7 @@ tile(Monitor *m)
mw = m->nmaster ? m->ww * m->mfact : 0; mw = m->nmaster ? m->ww * m->mfact : 0;
if ( m->nmaster == 1){ if ( m->nmaster == 1){
c = nexttiled(m->clients); c = nexttiled(m->clients);
altw = WIDTH(c) * m->wh / HEIGHT(c); /*use max window height but preserve aspect ratio */ altw = c->maxa > 0 ? m->wh * c->maxa : WIDTH(c) * m->wh / HEIGHT(c);
mw = c->mina > 0 && altw < mw ? altw : mw; mw = c->mina > 0 && altw < mw ? altw : mw;
} }
} }
@@ -2662,7 +2669,7 @@ fibonacci(Monitor *mon, int s) {
} }
if(i == 0) if(i == 0)
{ {
unsigned int altw = WIDTH(c) * mon->wh / HEIGHT(c); /*use max window height but preserve aspect ratio */ unsigned int altw = c->maxa > 0 ? mon->wh * c->maxa : WIDTH(c) * mon->wh / HEIGHT(c);
if(n == 1){ if(n == 1){
//if window has min aspect ratio (aka not infinitely adjustable to screen), center that window //if window has min aspect ratio (aka not infinitely adjustable to screen), center that window
if ( c->mina > 0 && altw < c->mon->mw ){ if ( c->mina > 0 && altw < c->mon->mw ){