Alexander/FitTrackee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

API & Client - remove password confirmation

Browse Source
This commit is contained in:
Sam
2022-03-13 08:39:50 +01:00
parent 8988a0266a
commit d8c4106fcf
9 changed files with 21 additions and 235 deletions
Download Patch File Download Diff File Expand all files Collapse all files

143
fittrackee/tests/users/test_auth_api.py
View File

@@ -25,7 +25,6 @@ class TestUserRegistration(ApiTestCaseMixin):
username='justatest',
email='test@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -53,7 +52,6 @@ class TestUserRegistration(ApiTestCaseMixin):
username=input_username,
email='another_email@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -76,7 +74,6 @@ class TestUserRegistration(ApiTestCaseMixin):
username='test',
email='test@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -96,7 +93,6 @@ class TestUserRegistration(ApiTestCaseMixin):
username='',
email='test@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -123,7 +119,6 @@ class TestUserRegistration(ApiTestCaseMixin):
username='a' * 31,
email='test@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -150,7 +145,6 @@ class TestUserRegistration(ApiTestCaseMixin):
username=input_username,
email='test@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -172,7 +166,6 @@ class TestUserRegistration(ApiTestCaseMixin):
username='test',
email='test@test',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -192,7 +185,6 @@ class TestUserRegistration(ApiTestCaseMixin):
username='test',
email='test@test.com',
password='1234567',
password_conf='1234567',
)
),
content_type='application/json',
@@ -200,27 +192,6 @@ class TestUserRegistration(ApiTestCaseMixin):
self.assert_400(response, "password: 8 characters required\n")
def test_it_returns_error_if_passwords_mismatch(self, app: Flask) -> None:
client = app.test_client()
response = client.post(
'/api/auth/register',
data=json.dumps(
dict(
username='test',
email='test@test.com',
password='12345678',
password_conf='87654321',
)
),
content_type='application/json',
)
self.assert_400(
response,
"password: password and password confirmation do not match\n",
)
def test_it_returns_error_if_payload_is_invalid(self, app: Flask) -> None:
client = app.test_client()
response = client.post(
@@ -242,7 +213,6 @@ class TestUserRegistration(ApiTestCaseMixin):
dict(
email='test@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -259,7 +229,6 @@ class TestUserRegistration(ApiTestCaseMixin):
dict(
username='test',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -276,23 +245,6 @@ class TestUserRegistration(ApiTestCaseMixin):
dict(
username='test',
email='test@test.com',
password_conf='12345678',
)
),
content_type='application/json',
)
self.assert_400(response)
def test_it_returns_error_if_password_confirmation_is_missing(
self, app: Flask
) -> None:
client = app.test_client()
response = client.post(
'/api/auth/register',
data=json.dumps(
dict(
username='test', email='test@test.com', password='12345678'
)
),
content_type='application/json',
@@ -564,7 +516,6 @@ class TestUserProfileUpdate(ApiTestCaseMixin):
bio='Nothing to tell',
birth_date='1980-01-01',
password='87654321',
password_conf='87654321',
)
),
headers=dict(Authorization=f'Bearer {auth_token}'),
@@ -672,63 +623,6 @@ class TestUserProfileUpdate(ApiTestCaseMixin):
self.assert_400(response)
def test_it_returns_error_if_passwords_mismatch(
self, app: Flask, user_1: User
) -> None:
client, auth_token = self.get_test_client_and_auth_token(
app, user_1.email
)
response = client.post(
'/api/auth/profile/edit',
content_type='application/json',
data=json.dumps(
dict(
first_name='John',
last_name='Doe',
location='Somewhere',
bio='just a random guy',
birth_date='1980-01-01',
password='87654321',
password_conf='876543210',
)
),
headers=dict(Authorization=f'Bearer {auth_token}'),
)
self.assert_400(
response,
'password: password and password confirmation do not match\n',
)
def test_it_returns_error_if_password_confirmation_is_missing(
self, app: Flask, user_1: User
) -> None:
client, auth_token = self.get_test_client_and_auth_token(
app, user_1.email
)
response = client.post(
'/api/auth/profile/edit',
content_type='application/json',
data=json.dumps(
dict(
first_name='John',
last_name='Doe',
location='Somewhere',
bio='just a random guy',
birth_date='1980-01-01',
password='87654321',
)
),
headers=dict(Authorization=f'Bearer {auth_token}'),
)
self.assert_400(
response,
'password: password and password confirmation do not match\n',
)
class TestUserPreferencesUpdate(ApiTestCaseMixin):
def test_it_updates_user_preferences(
@@ -1192,7 +1086,6 @@ class TestRegistrationConfiguration(ApiTestCaseMixin):
username='user4',
email='user4@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -1214,7 +1107,6 @@ class TestRegistrationConfiguration(ApiTestCaseMixin):
username='sam',
email='sam@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -1227,7 +1119,6 @@ class TestRegistrationConfiguration(ApiTestCaseMixin):
username='new',
email='new@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -1248,7 +1139,6 @@ class TestRegistrationConfiguration(ApiTestCaseMixin):
username='sam',
email='sam@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -1260,7 +1150,6 @@ class TestRegistrationConfiguration(ApiTestCaseMixin):
username='new',
email='new@test.com',
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -1331,12 +1220,7 @@ class TestPasswordUpdate(ApiTestCaseMixin):
response = client.post(
'/api/auth/password/update',
data=json.dumps(
dict(
token='xxx',
password='1234567',
)
),
data=json.dumps(dict()),
content_type='application/json',
)
@@ -1350,7 +1234,6 @@ class TestPasswordUpdate(ApiTestCaseMixin):
data=json.dumps(
dict(
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -1366,25 +1249,6 @@ class TestPasswordUpdate(ApiTestCaseMixin):
data=json.dumps(
dict(
token='xxx',
password_conf='12345678',
)
),
content_type='application/json',
)
self.assert_400(response)
def test_it_returns_error_if_password_confirmation_is_missing(
self, app: Flask
) -> None:
client = app.test_client()
response = client.post(
'/api/auth/password/update',
data=json.dumps(
dict(
token='xxx',
password='12345678',
)
),
content_type='application/json',
@@ -1424,7 +1288,6 @@ class TestPasswordUpdate(ApiTestCaseMixin):
dict(
token=token,
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',
@@ -1446,7 +1309,6 @@ class TestPasswordUpdate(ApiTestCaseMixin):
dict(
token=token,
password='1234567',
password_conf='1234567',
)
),
content_type='application/json',
@@ -1454,7 +1316,7 @@ class TestPasswordUpdate(ApiTestCaseMixin):
self.assert_400(response, 'password: 8 characters required\n')
def test_it_update_password(self, app: Flask, user_1: User) -> None:
def test_it_updates_password(self, app: Flask, user_1: User) -> None:
token = get_user_token(user_1.id, password_reset=True)
client = app.test_client()
@@ -1464,7 +1326,6 @@ class TestPasswordUpdate(ApiTestCaseMixin):
dict(
token=token,
password='12345678',
password_conf='12345678',
)
),
content_type='application/json',

31
fittrackee/tests/users/test_users_utils.py
View File

@@ -7,7 +7,7 @@ from fittrackee.users.exceptions import UserNotFoundException
from fittrackee.users.models import User
from fittrackee.users.utils.admin import set_admin_rights
from fittrackee.users.utils.controls import (
check_passwords,
check_password,
check_username,
is_valid_email,
register_controls,
@@ -70,13 +70,6 @@ class TestIsValidEmail:
class TestCheckPasswords:
def test_it_returns_error_message_string_if_passwords_do_not_match(
self,
) -> None:
assert check_passwords('password', 'pasword') == (
'password: password and password confirmation do not match\n'
)
@pytest.mark.parametrize(
('input_password_length',),
[
@@ -89,7 +82,7 @@ class TestCheckPasswords:
self, input_password_length: int
) -> None:
password = random_string(input_password_length)
assert check_passwords(password, password) == (
assert check_password(password) == (
'password: 8 characters required\n'
)
@@ -104,15 +97,7 @@ class TestCheckPasswords:
self, input_password_length: int
) -> None:
password = random_string(input_password_length)
assert check_passwords(password, password) == ''
def test_it_returns_multiple_errors(self) -> None:
password = random_string(3)
password_conf = random_string(8)
assert check_passwords(password, password_conf) == (
'password: password and password confirmation do not match\n'
'password: 8 characters required\n'
)
assert check_password(password) == ''
class TestIsUsernameValid:
@@ -170,7 +155,7 @@ class TestRegisterControls:
def test_it_calls_all_validators(self) -> None:
with patch(
self.module_path + 'check_passwords'
self.module_path + 'check_password'
) as check_passwords_mock, patch(
self.module_path + 'check_username'
) as check_username_mock, patch(
@@ -180,12 +165,9 @@ class TestRegisterControls:
self.valid_username,
self.valid_email,
self.valid_password,
self.valid_password,
)
check_passwords_mock.assert_called_once_with(
self.valid_password, self.valid_password
)
check_passwords_mock.assert_called_once_with(self.valid_password)
check_username_mock.assert_called_once_with(self.valid_username)
is_valid_email_mock.assert_called_once_with(self.valid_email)
@@ -195,7 +177,6 @@ class TestRegisterControls:
self.valid_username,
self.valid_email,
self.valid_password,
self.valid_password,
)
== ''
)
@@ -206,9 +187,7 @@ class TestRegisterControls:
username=invalid_username,
email=invalid_username,
password=random_string(8),
password_conf=random_string(8),
) == (
'username: 3 to 30 characters required\n'
'email: valid email must be provided\n'
'password: password and password confirmation do not match\n'
)