From 6911024f33b60be82f7b12d122d2e2443d49b687 Mon Sep 17 00:00:00 2001
From: Sam <sam@samr1.net>
Date: Sun, 19 Jun 2022 20:32:38 +0200
Subject: [PATCH] Client - display 'application:write' scope only if user is
 admin

---
 .../components/User/UserApps/AddUserApp.vue   | 28 ++++++++++++++++---
 fittrackee_client/src/utils/oauth.ts          |  3 +-
 2 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/fittrackee_client/src/components/User/UserApps/AddUserApp.vue b/fittrackee_client/src/components/User/UserApps/AddUserApp.vue
index 6893cc6e..dc64ffe9 100644
--- a/fittrackee_client/src/components/User/UserApps/AddUserApp.vue
+++ b/fittrackee_client/src/components/User/UserApps/AddUserApp.vue
@@ -49,7 +49,7 @@
               {{ $t('oauth2.APP.SCOPE.LABEL') }}*
             </div>
             <div
-              v-for="scope in oauth2_scopes"
+              v-for="scope in filtered_scopes"
               class="form-item-scope-checkboxes"
               :key="scope"
             >
@@ -86,12 +86,18 @@
 </template>
 
 <script setup lang="ts">
-  import { reactive } from 'vue'
+  import { computed, reactive } from 'vue'
 
   import { OAUTH2_STORE } from '@/store/constants'
   import { IOAuth2ClientPayload } from '@/types/oauth'
+  import { IAuthUserProfile } from '@/types/user'
   import { useStore } from '@/use/useStore'
-  import { oauth2_scopes } from '@/utils/oauth'
+  import { admin_oauth2_scopes, oauth2_scopes } from '@/utils/oauth'
+
+  interface Props {
+    authUser: IAuthUserProfile
+  }
+  const props = defineProps<Props>()
 
   const store = useStore()
   const appForm = reactive({
@@ -101,6 +107,9 @@
     redirect_uri: '',
   })
   const scopes: string[] = reactive([])
+  const filtered_scopes = computed(() =>
+    getScopes(props.authUser, admin_oauth2_scopes, oauth2_scopes)
+  )
 
   function createApp() {
     const payload: IOAuth2ClientPayload = {
@@ -108,7 +117,7 @@
       client_description: appForm.client_description,
       client_uri: appForm.client_uri,
       redirect_uris: [appForm.redirect_uri],
-      scope: scopes.join(' '),
+      scope: scopes.sort().join(' '),
     }
     store.dispatch(OAUTH2_STORE.ACTIONS.CREATE_CLIENT, payload)
   }
@@ -123,6 +132,17 @@
       scopes.push(scope)
     }
   }
+  function getScopes(
+    authUser: IAuthUserProfile,
+    admin_scopes: string[],
+    scopes: string[]
+  ) {
+    const filtered_scopes = [...scopes]
+    if (authUser.admin) {
+      filtered_scopes.push(...admin_scopes)
+    }
+    return filtered_scopes.sort()
+  }
 </script>
 
 <style scoped lang="scss">
diff --git a/fittrackee_client/src/utils/oauth.ts b/fittrackee_client/src/utils/oauth.ts
index fbbdfca0..62b34ec5 100644
--- a/fittrackee_client/src/utils/oauth.ts
+++ b/fittrackee_client/src/utils/oauth.ts
@@ -1,5 +1,4 @@
 export const oauth2_scopes = [
-  'application:write',
   'profile:read',
   'profile:write',
   'users:read',
@@ -7,3 +6,5 @@ export const oauth2_scopes = [
   'workouts:read',
   'workouts:write',
 ]
+
+export const admin_oauth2_scopes = ['application:write']